Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(readme) Add the Dart integration #2399

Merged
merged 4 commits into from
Jun 7, 2021
Merged

doc(readme) Add the Dart integration #2399

merged 4 commits into from
Jun 7, 2021

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Jun 7, 2021 •
edited
Loading

Description

This patch has started as: Hey, I want to add the Dart integration. I took the logo from https://svgporn.com/#search=dart.

And then I've noticed that our SVG files had incorrect permissions (0755 rather than 0644).

And then I've noticed that our SVG files were unoptimized. So I've optimized them with SVGO.

File Before (bytes) After (bytes)
c.svg 726 586
cpp.svg 825 705
csharp.svg 1206 1062
d.svg 10539 4179
dart.svg 1237
elixir.svg 7866 4611
go.svg 1455 1321
java.svg 1627 1407
js.svg 1699 875
php.svg 938 842
postgres.svg 4430 3953
python.svg 726 594
r.svg 1993 1320
ruby.svg 1738 1339
rust.svg 3109 2989
swift.svg 1072 862
total 39949 27882

Review

  • Add a short description of the change to the CHANGELOG.md file

@Hywan Hywan added 🎉 enhancement New feature! 📚 documentation Do you like to read? labels Jun 7, 2021
@Hywan Hywan self-assigned this Jun 7, 2021
@syrusakbary syrusakbary merged commit 0342e7e into wasmerio:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees

@Hywan Hywan

Labels
📚 documentation Do you like to read? 🎉 enhancement New feature!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hywan @syrusakbary